Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api gateway create bucket #149

Merged
merged 14 commits into from
Nov 19, 2024
Merged

Api gateway create bucket #149

merged 14 commits into from
Nov 19, 2024

Conversation

zinichakraborty
Copy link
Contributor

No description provided.

tmthecoder
tmthecoder requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@tmthecoder tmthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase/Merge your changes off of main & fix conflicts

tmthecoder
tmthecoder requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@tmthecoder tmthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple errors seen from the test suite that ran on GitHub actions. Please look at the other PRs that have been successfully merged to base your implementation & tests off of

tmthecoder
tmthecoder approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@tmthecoder tmthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, still some errors left that needed fixing, look at what they were/how I fixed for future reference

@tmthecoder tmthecoder merged commit 263bd26 into main Nov 19, 2024
7 checks passed
@tmthecoder tmthecoder linked an issue Nov 19, 2024 that may be closed by this pull request
Juno API Gateway Create Bucket #140
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmthecoder tmthecoder tmthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Juno API Gateway Create Bucket
2 participants
@zinichakraborty @tmthecoder