Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint errors #82

Open
michaelchin opened this issue Jul 28, 2022 · 6 comments · Fixed by #84
Open

fix eslint errors #82

michaelchin opened this issue Jul 28, 2022 · 6 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request low Low priority

Comments

@michaelchin
Copy link
Contributor

No description provided.

@michaelchin michaelchin added enhancement New feature or request medium Medium priority labels Jul 28, 2022
@michaelchin michaelchin self-assigned this Jul 28, 2022
@michaelchin
Copy link
Contributor Author

@matthewmerkas @yiyanw

I am going to sort out the eslint errors/warnings and Pettier format stuff during the next a couple of weeks. To avoid code change conflict, please let me know if you have local changes and which files you are working on. Thanks.

@matthew-merkas
Copy link
Contributor

Hey @michaelchin, I just got back from a little camping trip but I'm keen to get a bunch of work done through semester. I don't have any local changes as of yet, but I'll be working on AgeSlider.tsx to fix the prev/next button behaviour. I'll also be working on SettingMenuPage.tsx and probably Main.tsx to add a dark mode toggle and get settings saved in localstorage. I can hold off a couple of days so you can sort out the ESlint/Prettier stuff to make future merges less headache-inducing?

@michaelchin
Copy link
Contributor Author

Hey @michaelchin, I just got back from a little camping trip but I'm keen to get a bunch of work done through semester. I don't have any local changes as of yet, but I'll be working on AgeSlider.tsx to fix the prev/next button behaviour. I'll also be working on SettingMenuPage.tsx and probably Main.tsx to add a dark mode toggle and get settings saved in localstorage. I can hold off a couple of days so you can sort out the ESlint/Prettier stuff to make future merges less headache-inducing?

Thanks Matthew. No need to hold off for me. I will ask before working on any file.

@michaelchin michaelchin linked a pull request Aug 1, 2022 that will close this issue
@michaelchin
Copy link
Contributor Author

@yiyanw

I have merged this PR. Please pull the changes and see if there is any conflicts.

@michaelchin
Copy link
Contributor Author

@yiyanw

And also please config Prettier in your editor to "format on save" or run npx prettier -- write . in "src" folder before committing changes.

@yiyanw
Copy link
Contributor

yiyanw commented Aug 1, 2022

I had checked the code, no conflicts.

@michaelchin michaelchin added low Low priority and removed medium Medium priority labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants