-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix eslint errors #82
Comments
I am going to sort out the eslint errors/warnings and Pettier format stuff during the next a couple of weeks. To avoid code change conflict, please let me know if you have local changes and which files you are working on. Thanks. |
Hey @michaelchin, I just got back from a little camping trip but I'm keen to get a bunch of work done through semester. I don't have any local changes as of yet, but I'll be working on AgeSlider.tsx to fix the prev/next button behaviour. I'll also be working on SettingMenuPage.tsx and probably Main.tsx to add a dark mode toggle and get settings saved in localstorage. I can hold off a couple of days so you can sort out the ESlint/Prettier stuff to make future merges less headache-inducing? |
Thanks Matthew. No need to hold off for me. I will ask before working on any file. |
I have merged this PR. Please pull the changes and see if there is any conflicts. |
And also please config Prettier in your editor to "format on save" or run |
I had checked the code, no conflicts. |
No description provided.
The text was updated successfully, but these errors were encountered: