Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiledImage node in Texture2D not behaving (update --> nodegraphs are not working) #182

Open
kvrbharadwaj2 opened this issue Dec 31, 2021 · 3 comments
Assignees

Comments

@kvrbharadwaj2
Copy link

kvrbharadwaj2 commented Dec 31, 2021

Used files from MaterialX https://github.com/materialx/MaterialX/blob/main/resources/Materials/Examples/StandardSurface/
both brick and wood files which load .jpg files to "tiledimage" node are not behaving properly. (maybe color3 values are not generated).
when replaced with "image" node "base" node is getting proper color3 values.

Also tried generating osl shaders from mtlx and used in cycles script which worked fine (but we need to give absolute paths for textures not relative)

so the problem maybe with "tiledimage" node. it is in Texture2D in MaterialX editor

Specs :
Windows 8.1
Blender 3.0
Addon 1.0.65

Update

Also tried "Contrast" node with both pivot 1.0 and 0.0 same result (just white colored cube)
implemented contrast node with individual subtract,multiply and add nodes (pivot should be 0.0 color blue) -> correct result
so changed pivot values in MX_STD_contrast in /hdusd/mx_nodes/get_stdlib_defs.py to 0.0
still "contrast" node renders white cube only

seems like nodegraph definitions are not working properly.
because both contrast and tiledimage are from libraries/stdlib/stdlib_ng.mtlx

you guys implemented nodegraphs as blender "nodes"
actually they should be implemented as blender "nodegroups"
because when you import materialx file, if there are custom nodegraphs, materialx has to search for that nodegraph in custom library modules and then import them as blender "nodegroup" which actually knows computation.
nodedefs are implemented in shader langs and nodegraphs are implemented in mtlx which are computation graphs.
so only those nodedefs which has standard implementation(in materialx std_lib.mtlx) becomes nodes everything else should become nodegroups in blender.

only then actual materialx is implemented.

@kvrbharadwaj2 kvrbharadwaj2 changed the title TiledImage node in Texture2D not behaving TiledImage node in Texture2D not behaving (update --> nodegraphs are not working) Jan 1, 2022
@DagerD
Copy link
Contributor

DagerD commented Jan 11, 2022

Hi. Thank you, we will think about this.

@DagerD DagerD self-assigned this Jan 11, 2022
@bsavery
Copy link
Contributor

bsavery commented Jun 10, 2022

@DagerD please make a ticket to group "Nodegraph" in Blender.

@DagerD
Copy link
Contributor

DagerD commented Jul 19, 2022

Created ticket BLEN-170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants