Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] BasePointOfSaleResponse spec is wrong #115

Open
JustSamuel opened this issue Dec 26, 2023 · 2 comments
Open

[BUG] BasePointOfSaleResponse spec is wrong #115

JustSamuel opened this issue Dec 26, 2023 · 2 comments

Comments

@JustSamuel
Copy link
Contributor

The Spec does not contain useAuthentication and revision, however the function parsePOSToBasePOS in the revision-to-response always adds these. This mistake crept in because we force the return value to the type.

This is a simple fix, but simply changing the type does add some type errors here and there. The fixes are either always adding the revision and authentication, or making them optional, or removing them all together.

For now I have set dissalowExtraProperties to false in the transaction-controller.ts test cases to make sure they pass.

@JustSamuel
Copy link
Contributor Author

Same goes for the TransactionReportResponse

@JustSamuel
Copy link
Contributor Author

JustSamuel commented Dec 26, 2023

TODO fix test cases

  • Remove all disallowExtraProperties false in transaction-controller.ts
  • Remove all disallowExtraProperties false in user-controller.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant