fix(signup): admin (un)subscribe possible before sign-up list opens #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not be possible, as this prevents someone from editing the activity due to the underlying limitations to editing (yes, ideally that should be fixed but that is complex).
tomudding
force-pushed
the
fix/admin-signup-and-signoff-possible-outside-sign-up-list-being-open
branch
from
ab163de to
1405d12
Compare
github-actions bot
added a commit
that referenced
this pull request
Jan 11, 2025
Tom Udding: Merge pull request #1972 from tomudding/fix/admin-signup-and-signoff-possible-outside-sign-up-list-being-open fix(signup): admin (un)subscribe possible before sign-up list opens Co-authored-by: tomudding <tomudding@users.noreply.github.com>
github-actions bot
added a commit
to tomudding/gewisweb
that referenced
this pull request
Jan 11, 2025
Tom Udding: Merge pull request GEWIS#1972 from tomudding/fix/admin-signup-and-signoff-possible-outside-sign-up-list-being-open fix(signup): admin (un)subscribe possible before sign-up list opens Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should not be possible, as this prevents someone from editing the activity due to the underlying limitations to editing (yes, ideally that should be fixed but that is complex).
Related issues/external references
Fixes GH-1187.
Types of changes