Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(company): localised text comparisons expecting null instead of empty string #1870

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

tomudding
Copy link
Member

Description

Changes were made to the LocaliseText view helper in GH-1821. Unfortunately, I did not check if there were any existing checks against the original null output. Four of these checks were still present in our code base. This PR resolves that by changing the null to '' (empty string).

Related issues/external references

Fixes GH-1869.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Other (please specify)

@tomudding tomudding force-pushed the fix/job-attachments-always-shown branch from 9288a5f to a2beb49 Compare July 23, 2024 09:11
@tomudding tomudding merged commit 8ecd310 into GEWIS:main Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job postings: attachment URL always visible
1 participant