Removed the local sumdomain checks if a variable has been filled from a GEOS restart

[atrayano]

This was causing layout regression failures

Name and Institution (Required)

Name: Atanas Trayanov
Institution: NASA GSFC

Confirm you have reviewed the following documentation

• [x ] Contributing guidelines

Describe the update

A local reduction (sum) was used to determine if a variablle has been filled for a restart. For MODEL_GEOS this lead to a layout regression failure

Please provide a clear and concise overview of the update.

Expected changes

Please provide details on how this update will impact model output and include plots or tables as needed.

Reference(s)

If this is a science update, please provide a literature citation.

Related Github Issue(s)

Please link to the corresponding Github issue here. If fixing a bug, there should be an issue describing it with steps to reproduce.

[mathomp4]

Thanks @atrayano I'll try and give this a try next week. Hopefully this (temporarily) fixes the great hemco mystery.

As a note, @lizziel has opened an issue on the mothership repo here: geoschem#305 for the modern HEMCO code.

[lizziel]

@atrayano, skipping the check will fix the layout problem but it means you will then always assume the restart fields were in the restart file. You should probably verify this is always true for GEOS before applying this fix.

[mathomp4]

@atrayano, skipping the check will fix the layout problem but it means you will then always assume the restart fields were in the restart file. You should probably verify this is always true for GEOS before applying this fix.

@lizziel We believe this is true. If I read this:

https://github.com/GEOS-ESM/GEOSchem_GridComp/blob/develop/HEMCO_GridComp/HEMCO_Registry.rc

right, we should always have defaults when we bootstrap. I'm not sure if they are good defaults, but they are there and 0 or higher (which seems good for emissions 😄 )

[mathomp4]

I have tested this. It does seem to solve the issue but it is also non-zero-diff. So I'll merge and release. It'll be one of our geos/ tags as we are of course way behind mothership HEMCO.