Add LVARRAY_ERROR_IF_PRINTF() macro to prinnt fancyer messages on errors #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbett5
approved these changes
Mar 29, 2022
src/SparsityPattern.hpp
Outdated
| @@ -130,8 +130,8 @@ class SparsityPattern : protected SparsityPatternView< COL_TYPE, INDEX_TYPE, BUF | |||
| void resizeFromRowCapacities( INDEX_TYPE const nRows, INDEX_TYPE const nCols, INDEX_TYPE const * const rowCapacities ) | |||
| { | |||
| LVARRAY_ERROR_IF( !arrayManipulation::isPositive( nCols ), "nCols must be positive." ); | |||
| LVARRAY_ERROR_IF( nCols - 1 > std::numeric_limits< COL_TYPE >::max(), | |||
| "COL_TYPE must be able to hold the range of columns: [0, " << nCols - 1 << "]." ); | |||
| LVARRAY_ERROR_IF_PRINTF( nCols - 1 > std::numeric_limits< COL_TYPE >::max(), | |||
There was a problem hiding this comment.
This is not device code so I'm not sure it makes sense to change.
src/SparsityPatternView.hpp
Outdated
| @@ -438,8 +439,8 @@ class SparsityPatternView : protected ArrayOfSetsView< COL_TYPE, INDEX_TYPE, BUF | |||
| { | |||
| LVARRAY_ERROR_IF( !arrayManipulation::isPositive( nrows ), "nrows must be positive." ); | |||
| LVARRAY_ERROR_IF( !arrayManipulation::isPositive( ncols ), "ncols must be positive." ); | |||
| LVARRAY_ERROR_IF( ncols - 1 > std::numeric_limits< COL_TYPE >::max(), | |||
| "COL_TYPE must be able to hold the range of columns: [0, " << ncols - 1 << "]." ); | |||
| LVARRAY_ERROR_IF_PRINTF( ncols - 1 > std::numeric_limits< COL_TYPE >::max(), | |||
|
Ok thanks, I'll change the code. I was indeed wondering how we tested LVArray, thanks for the explanation i'll do so. |
rrsettgast
reviewed
Mar 29, 2022
| LVARRAY_ERROR_IF( !arrayManipulation::isPositive( i ) || i >= this->size(), \ | ||
| "Bounds Check Failed: i=" << i << " size()=" << this->size() ) | ||
| LVARRAY_ERROR_IF_PRINTF( !arrayManipulation::isPositive( i ) || i >= this->size(), \ | ||
| "Bounds Check Failed: i=%" PRId64 " size()=%" PRId64, (int64_t)i, (int64_t)this->size() ) |
There was a problem hiding this comment.
where is PRId64 defined, and what if the index is not 64 bit?
There was a problem hiding this comment.
PRId64 is in inttypes.h https://www.cplusplus.com/reference/cinttypes/,
Int are casted into int64 to be sure not to have overflow.
added 3 commits
March 31, 2022 14:58
* Add execution policy parameter to ArrayOfSets::assimilate(). Add new method ArrayOfArrays::resizeFromOffsets(). * Add unit test for ArrayOfArrays::resizeFromOffsets. * Extract common code of ArrayOfArraysView::resizeFrom functions
…/LvArray into feature/deviceErrorMessage
|
Any reason you closed this, it seems quite nice. |
|
It raised errors in geosx that i failed to fix. And i have no time at the
moment to do it.
You can reopen if you want.
Regards,
XL
Le mar. 7 juin 2022, 18:59, Ben Corbett ***@***.***> a écrit :
… Any reason you closed this, it seems quite nice.
—
Reply to this email directly, view it on GitHub
<#255 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL44MTWSSLOKQSY6SLZJ23VN55X7ANCNFSM5RVPHDXQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve issue #254.
Added new macro to use printf on device with clearer message.
Still not perfect, we don't know were we are when the error is raised.
Now the dimensions are correctly printed:
***** ERROR
***** LOCATION: /work206/workrd/users/lacoste_x/remote_builds/GEOSX/src/coreComponents/LvArray/src/ArraySlice.hpp:295
***** Block: [3, 0, 0]
***** Thread: [16, 0, 0]
***** Controlling expression (should be false): index < 0 || index >= m_dims[ 0 ]
***** MSG: Array Bounds Check Failed: index=8 m_dims[0]=8