This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Siembol common: reworking storm kafka writer (#525)
- Loading branch information
1 parent
76a9366
commit 8d2905a
Showing
43 changed files
with
320 additions
and
353 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
...ing-storm/src/main/java/uk/co/gresearch/siembol/alerts/storm/AlertingKafkaWriterBolt.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| package uk.co.gresearch.siembol.alerts.storm; | ||
| import java.lang.invoke.MethodHandles; | ||
| import java.util.ArrayList; | ||
|
|
||
| import org.apache.storm.tuple.Tuple; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import uk.co.gresearch.siembol.alerts.common.AlertingEngineType; | ||
| import uk.co.gresearch.siembol.common.error.ErrorMessage; | ||
| import uk.co.gresearch.siembol.common.error.ErrorType; | ||
| import uk.co.gresearch.siembol.alerts.common.AlertingResult; | ||
| import uk.co.gresearch.siembol.alerts.protection.RuleProtectionSystem; | ||
| import uk.co.gresearch.siembol.alerts.protection.RuleProtectionSystemImpl; | ||
| import uk.co.gresearch.siembol.alerts.storm.model.*; | ||
| import uk.co.gresearch.siembol.common.model.AlertingStormAttributesDto; | ||
| import uk.co.gresearch.siembol.common.storm.KafkaWriterAnchor; | ||
| import uk.co.gresearch.siembol.common.storm.KafkaWriterBoltBase; | ||
| import uk.co.gresearch.siembol.common.storm.KafkaWriterMessage; | ||
|
|
||
| public class AlertingKafkaWriterBolt extends KafkaWriterBoltBase { | ||
| private static final long serialVersionUID = 1L; | ||
| private static final Logger LOG = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); | ||
| private static final String WRONG_ALERTS_FIELD_MESSAGE = "Wrong alerts type in tuple"; | ||
| private static final String WRONG_EXCEPTION_FIELD_MESSAGE = "Wrong exceptions type in tuple"; | ||
| private static final String RULE_PROTECTION_ERROR_MESSAGE = | ||
| "The rule: %s reaches the limit\n hourly matches: %d, daily matches: %d, alert: %s"; | ||
| private static final String SEND_MSG_LOG = "Sending message {}\n to {} topic"; | ||
| private static final String MISSING_CORRELATION_KEY_MSG = "Missing key in correlation alert %s"; | ||
|
|
||
| private final String errorSensorType; | ||
| private final String errorTopic; | ||
| private final String outputTopic; | ||
| private final String correlationTopic; | ||
| private RuleProtectionSystem ruleProtection; | ||
|
|
||
| public AlertingKafkaWriterBolt(AlertingStormAttributesDto attributes) { | ||
| super(attributes.getKafkaProducerProperties().getProperties()); | ||
| this.outputTopic = attributes.getOutputTopic(); | ||
| this.errorTopic = attributes.getKafkaErrorTopic(); | ||
| this.correlationTopic = attributes.getCorrelationOutputTopic(); | ||
| AlertingEngineType engineType = AlertingEngineType.valueOfName(attributes.getAlertingEngine()); | ||
| errorSensorType = engineType.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public void execute(Tuple tuple) { | ||
| Object matchesObject = tuple.getValueByField(TupleFieldNames.ALERTING_MATCHES.toString()); | ||
| if (!(matchesObject instanceof AlertMessages)) { | ||
| LOG.error(WRONG_ALERTS_FIELD_MESSAGE); | ||
| throw new IllegalStateException(WRONG_ALERTS_FIELD_MESSAGE); | ||
| } | ||
| AlertMessages matches = (AlertMessages)matchesObject; | ||
|
|
||
| Object exceptionsObject = tuple.getValueByField(TupleFieldNames.ALERTING_EXCEPTIONS.toString()); | ||
| if (!(exceptionsObject instanceof ExceptionMessages)) { | ||
| LOG.error(WRONG_EXCEPTION_FIELD_MESSAGE); | ||
| throw new IllegalStateException(WRONG_EXCEPTION_FIELD_MESSAGE); | ||
| } | ||
| ExceptionMessages exceptions = (ExceptionMessages)exceptionsObject; | ||
| var messages = new ArrayList<KafkaWriterMessage>(); | ||
|
|
||
| for (var match : matches) { | ||
| AlertingResult matchesInfo = ruleProtection.incrementRuleMatches(match.getFullRuleName()); | ||
| int hourlyMatches = matchesInfo.getAttributes().getHourlyMatches(); | ||
| int dailyMatches = matchesInfo.getAttributes().getDailyMatches(); | ||
|
|
||
| if (match.getMaxHourMatches().intValue() < hourlyMatches | ||
| || match.getMaxDayMatches().intValue() < dailyMatches) { | ||
| String msg = String.format(RULE_PROTECTION_ERROR_MESSAGE, | ||
| match.getFullRuleName(), hourlyMatches, dailyMatches, match.getAlertJson()); | ||
| LOG.debug(msg); | ||
| exceptions.add(msg); | ||
| continue; | ||
| } | ||
|
|
||
| if (match.isVisibleAlert()) { | ||
| LOG.debug(SEND_MSG_LOG, match.getAlertJson(), outputTopic); | ||
| messages.add(new KafkaWriterMessage(outputTopic, match.getAlertJson())); | ||
| } | ||
|
|
||
| if (match.isCorrelationAlert()) { | ||
| if (match.getCorrelationKey().isEmpty()) { | ||
| String errorMsg = String.format(MISSING_CORRELATION_KEY_MSG, match.getAlertJson()); | ||
| LOG.error(errorMsg); | ||
| throw new IllegalStateException(errorMsg); | ||
| } | ||
|
|
||
| LOG.debug(SEND_MSG_LOG, match.getAlertJson(), correlationTopic); | ||
| messages.add(new KafkaWriterMessage(correlationTopic, | ||
| match.getCorrelationKey().get(), | ||
| match.getAlertJson())); | ||
| } | ||
| } | ||
|
|
||
| for (var exception : exceptions) { | ||
| String errorMsgToSend = getErrorMessageToSend(exception); | ||
| LOG.debug(SEND_MSG_LOG, errorMsgToSend, errorTopic); | ||
| messages.add(new KafkaWriterMessage(errorTopic, errorMsgToSend)); | ||
| } | ||
|
|
||
| var anchor = new KafkaWriterAnchor(tuple); | ||
| super.writeMessages(messages, anchor); | ||
| } | ||
|
|
||
| @Override | ||
| public void prepareInternally() { | ||
| ruleProtection = new RuleProtectionSystemImpl(); | ||
| } | ||
|
|
||
| private String getErrorMessageToSend(String errorMsg) { | ||
| ErrorMessage error = new ErrorMessage(); | ||
| error.setErrorType(ErrorType.ALERTING_ERROR); | ||
| error.setFailedSensorType(errorSensorType); | ||
| error.setMessage(errorMsg); | ||
| return error.toString(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149 changes: 0 additions & 149 deletions
149
...ng/alerting-storm/src/main/java/uk/co/gresearch/siembol/alerts/storm/KafkaWriterBolt.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.