Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More commands #4

Merged
merged 39 commits into from
Oct 28, 2024
Merged

More commands #4

merged 39 commits into from
Oct 28, 2024

Conversation

ChocolateLoverRaj
Copy link
Contributor

@ChocolateLoverRaj ChocolateLoverRaj commented May 16, 2024 •
edited
Loading

I'll be adding more commands to this PR, but for now the board version command is ready to merge.

Fixes #1

@ChocolateLoverRaj ChocolateLoverRaj force-pushed the more-commands branch 2 times, most recently from beb69e6 to f7e4bae Compare May 17, 2024 16:25
@ChocolateLoverRaj ChocolateLoverRaj mentioned this pull request May 17, 2024
Closed
@lleyton
Copy link
Member

lleyton commented Jun 3, 2024

Looking good so far, let me know when you think the PR is ready for merge. Unsure if you want to add more commands or not.

@ChocolateLoverRaj
Use clap for an actual ectool CLI
b84a185
@ChocolateLoverRaj
Board version command
1ba33c6
@ChocolateLoverRaj
Get command versions
227d7ad
@ChocolateLoverRaj
Command version constants
fded85b
@ChocolateLoverRaj
Set fan target RPM
1d61b72
@ChocolateLoverRaj
Get EC features
a94d8ce
@ChocolateLoverRaj
Get number of fans
ed15d21 
Includes a big change that needs a fd to be provided to all ec command functions
@ChocolateLoverRaj
Get fan RPM
14f2a73
@ChocolateLoverRaj
ectool console
1120872
@ChocolateLoverRaj
Battery command
5e1b846
@ChocolateLoverRaj
Charge control commands
7f4d0aa
@ChocolateLoverRaj
Add hello and console commands for cros_fp
a33802e 
Made big changes to how the ec command function works to allow different input and output sizes at runtime instead of hard-coding max sizes. Initializes the minimum amount of memory necessary for an ec command.
@ChocolateLoverRaj
remove unused EcInterface enum
614d48d
@ChocolateLoverRaj
fp-info command
4bfb52f
@ChocolateLoverRaj
fp-stats command
2808fdb
@ChocolateLoverRaj
set fp seed command
1d1d30a 
This command can only be run once per reboot (I'm pretty sure) so it can be hard to debug. Luckily it worked 1st try for me.
@ChocolateLoverRaj
fp mode command
06efbf5 
The same EC command is used for changing the fp mode and also just getting the fp mode.
@ChocolateLoverRaj
wait_event function
cb213aa 
The function can wait for any event and detect the type of the event. It has in depth Rust-safe types for the fingerprint events.
@ChocolateLoverRaj
Use &mut File instead of raw fd for safe functions
9625eb1
@ChocolateLoverRaj
Download fp frame and templates
cc8858e
@ChocolateLoverRaj
Move charge control subcommand to new file
4a81f0c
@ChocolateLoverRaj
Upload template command
c4b3560 
Also includes a fix for downloading templates
@ChocolateLoverRaj
Add clap feature to crosec for better fp-mode command
6da00c5
@ChocolateLoverRaj
Copy link
Contributor Author

@lleyton I'm done adding more commands. I think this PR is ready to merge.

@ChocolateLoverRaj
Use trait for File in fp_mode
a64baa9
@ChocolateLoverRaj
Some improvements
a2d5504 
Added an async wait_event function, added get encryption status function, made some more functions use generic trait for file.
@lleyton
Copy link
Member

lleyton commented Jun 21, 2024 •
edited
Loading

Thanks, I'll review it soon. Might be a bit, since I'm still OOO

@ChocolateLoverRaj
Add HostEvent enum
a8121a0 
Particularly, the InterfaceReady event is useful for knowing when the FPMCU was turned on.
@ChocolateLoverRaj
No unused deps
980e60e
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 2, 2024
View reviewed changes
crosec/src/commands/fp_download.rs Fixed Show fixed Hide fixed
crosec/src/commands/fp_download.rs Fixed Show fixed Hide fixed
crosec/src/commands/fp_mode.rs Fixed Show fixed Hide fixed
crosec/src/commands/fp_mode.rs Fixed Show fixed Hide fixed
crosec/src/commands/set_fan_target_rpm.rs Fixed Show fixed Hide fixed
crosec/src/wait_event/event.rs Fixed Show fixed Hide fixed
crosec/src/wait_event/event.rs Fixed Show fixed Hide fixed
ectool/src/main.rs Fixed Show fixed Hide fixed
ectool/src/main.rs Fixed Show fixed Hide fixed
ectool/src/main.rs Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 3, 2024
View reviewed changes
crosec/src/wait_event/event.rs Fixed Show fixed Hide fixed
crosec/src/wait_event/event.rs Fixed Show fixed Hide fixed
crosec/src/wait_event/event.rs Fixed Show fixed Hide fixed
crosec/src/wait_event/event.rs Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 4, 2024
View reviewed changes
crosec/src/commands/charge_control.rs Fixed Show fixed Hide fixed
crosec/src/commands/set_fan_target_rpm.rs
Comment on lines +36 to +40
pub fn ec_cmd_set_fan_target_rpm(
file: &mut File,
rpm: u32,
fan_index: Option<u8>,
) -> EcCmdResult<()> {

Check warning

Code scanning / clippy

this function depends on never type fallback being () Warning

this function depends on never type fallback being ()
crosec/src/console.rs
use crate::ec_command::{ec_command_bytemuck, ec_command_with_dynamic_output_size};
use crate::EcCmdResult;

pub fn console(file: &mut File, protocol_info: &EcResponseGetProtocolInfo) -> EcCmdResult<String> {

Check warning

Code scanning / clippy

this function depends on never type fallback being () Warning

this function depends on never type fallback being ()
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 6, 2024
View reviewed changes
crosec/src/commands/charge_control.rs
Comment on lines +47 to +50
pub fn set_charge_control<File: AsRawFd>(
file: &mut File,
charge_control: ChargeControl,
) -> EcCmdResult<()> {

Check warning

Code scanning / clippy

this function depends on never type fallback being () Warning

this function depends on never type fallback being ()
ectool/src/charge_current_limit_subcommand.rs Fixed Show fixed Hide fixed
@lleyton lleyton merged commit 94bfb87 into FyraLabs:main Oct 28, 2024
3 checks passed
@lleyton
Copy link
Member

lleyton commented Oct 28, 2024

Sorry, forgot about this. Looks good! Feel free to make more PRs (and please ping me on Discord or Matrix if you need my attention.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement fingerprint commands
2 participants
@ChocolateLoverRaj @lleyton