chore: update actions and remove unused code

Fyko · May 6, 2024 · e08edab · e08edab
1 parent 236c330
commit e08edab
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/.github/workflows/book.yml b/.github/workflows/book.yml
@@ -24,14 +24,14 @@ jobs:
 
       - name: Setup Pages
         id: pages
-        uses: actions/configure-pages@v4
+        uses: actions/configure-pages@v5
 
       - name: Run Clippy
         working-directory: book
         run: mdbook build
 
       - name: Upload Pages Artifact
-        uses: actions/upload-pages-artifact@v2
+        uses: actions/upload-pages-artifact@v3
         with:
           path: book/book
 
@@ -48,4 +48,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v3
+        uses: actions/deploy-pages@v4
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -58,7 +58,7 @@ jobs:
         run: cargo make cov-ci
 
       - name: Upload coverage data to codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
         with:

diff --git a/scyllax-cli/src/migrator.rs b/scyllax-cli/src/migrator.rs
@@ -1,5 +1,6 @@
 use std::{
     borrow::Cow,
+    fmt::Display,
     fs::ReadDir,
     path::{Path, PathBuf},
     sync::Arc,
@@ -18,13 +19,9 @@ use crate::model::{DeleteByVersion, MigrationQueries, UpsertMigration};
 
 /// A marker struct provided to the [`Migrator`] to indicate that it should run up migrations.
 pub struct UpMigration;
-trait UpMigrationExt {}
-impl UpMigrationExt for UpMigration {}
 
 /// A marker struct provided to the [`Migrator`] to indicate that it should run down migrations.
 pub struct DownMigration;
-trait DownMigrationExt {}
-impl DownMigrationExt for DownMigration {}
 
 #[async_trait]
 pub trait MigrationMode {
@@ -251,11 +248,11 @@ impl<K: MigrationMode> TryFrom<Cow<'_, str>> for MigrationFolder<K> {
     }
 }
 
-impl<K: MigrationMode> ToString for MigrationFolder<K> {
-    /// Convert the migration folder to a string, which is the version and description joined by an
-    /// underscore.
-    fn to_string(&self) -> String {
-        format!("{}_{}", self.version, self.description.replace(' ', "_"))
+/// Convert the migration folder to a string, which is the version and description joined by an
+/// underscore.
+impl<K: MigrationMode> Display for MigrationFolder<K> {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "{}_{}", self.version, self.description.replace(' ', "_"))
     }
 }