This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
fixes usage of waitFor to render component tests
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeLo123
added
the
general issue
JakeLo123
force-pushed
the
83-correct-component-tests-usage-of-testing-library-and-async
branch
from
0e4bb3f to
4529d3a
Compare
JakeLo123
requested review from
mooreds,
dmackinn,
BriDavidson and
david-chalk
BriDavidson
suggested changes
Feb 16, 2024
that got fixed on this PR, so it's not an effect of this branch. |
BriDavidson
approved these changes
Feb 21, 2024
dmackinn
approved these changes
Feb 21, 2024
dmackinn
deleted the
83-correct-component-tests-usage-of-testing-library-and-async
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR and why do we need it?
Addressing issue #83. The component tests (buttons, and HOC tests) use waitFor to render components. This can cause unexpected behavior.
AfterEach... jest.clearAllMocks()in tests that don't use mocks.toBeCalled()(deprecated) totoHaveBeenCalled()Pre-Merge Checklist (if applicable)