This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
adds error handling to main provider #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeLo123
requested review from
mooreds,
dmackinn,
BriDavidson and
david-chalk
BriDavidson
previously approved these changes
Feb 12, 2024
david-chalk
suggested changes
Feb 12, 2024
JakeLo123
force-pushed
the
77-provider-needs-error-handling
branch
from
9cc6dfd to
52f61cd
Compare
…ject to the wrong type of object * Fixes an issue where onRedirectFailure was getting invoked on refresh, not redirect and adds test coverage for that.
JakeLo123
force-pushed
the
77-provider-needs-error-handling
branch
from
52f61cd to
7a85876
Compare
david-chalk
approved these changes
Feb 12, 2024
dmackinn
approved these changes
Feb 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR and why do we need it?
Adds error handling to the
/merequest so we don't set the user object to the wrong type of objectThe issue is fully described by #77. This branch should fix the behavior described by the steps to reproduce from the linked issue (#77)
Changes
/meresponse and changes paths if failure.onRedirectFailurewas getting invoked on refresh, not redirect and adds test coverage for that.Pre-Merge Checklist (if applicable)