Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Correct component tests usage of testing-library and async #83

Closed
JakeLo123 opened this issue Feb 15, 2024 · 0 comments · Fixed by #84
Closed

Correct component tests usage of testing-library and async #83

JakeLo123 opened this issue Feb 15, 2024 · 0 comments · Fixed by #84
Assignees
@JakeLo123
Labels
general issue not necessarily an observable bug, but needs change

Comments

@JakeLo123
Copy link
Collaborator

Correct component tests usage of testing-library and async

Description

The component tests (buttons, and HOC tests) use waitFor to render components. This can cause unexpected behavior.
This is the same pattern as issue #62.

Relevant docs... https://testing-library.com/docs/dom-testing-library/api-async#waitfor

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.
@JakeLo123 JakeLo123 added the general issue not necessarily an observable bug, but needs change label Feb 15, 2024
@JakeLo123 JakeLo123 self-assigned this Feb 15, 2024
@JakeLo123 JakeLo123 mentioned this issue Feb 15, 2024
Merged
1 task
@JakeLo123 JakeLo123 linked a pull request Feb 15, 2024 that will close this issue
fixes usage of waitFor to render component tests #84
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JakeLo123 JakeLo123

Labels
general issue not necessarily an observable bug, but needs change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes usage of waitFor to render component tests FusionAuth/fusionauth-react-sdk
1 participant
@JakeLo123