Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const generic feature toggle, parser and errors. #6926

Merged
merged 8 commits into from
Feb 17, 2025

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Feb 12, 2025

Description

This PR is part of #6860, and it is officially introducing the const_generic feature toggle.

For the moment, it is parsing syntax such as const N: u64 and it is returning an error explaining that the feature is off; on the other hand, it is also returning an error saying that const generics are still not supported in impl traits when the feature is on. Future PRs will replicate this error in all possible places.

Nothing else is implemented and it is reserved for future PRs.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #6926 will not alter performance

Comparing xunilrj/const-generic-feature-toggle (0373c30) with master (1589951)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj marked this pull request as ready for review February 12, 2025 21:16
@xunilrj xunilrj requested review from a team as code owners February 12, 2025 21:16
@xunilrj xunilrj mentioned this pull request Jan 24, 2025
10 tasks
@xunilrj xunilrj self-assigned this Feb 12, 2025
@IGI-111 IGI-111 requested a review from a team February 17, 2025 09:48
@IGI-111 IGI-111 enabled auto-merge (squash) February 17, 2025 13:55
@tritao
Copy link
Contributor

tritao commented Feb 17, 2025

@FuelLabs/tooling can you review this one?

@IGI-111 IGI-111 merged commit d8854fa into master Feb 17, 2025
42 checks passed
@IGI-111 IGI-111 deleted the xunilrj/const-generic-feature-toggle branch February 17, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants