-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore double backslashes (newlines) in Latex (#784) #792
base: master
Are you sure you want to change the base?
Conversation
Here is a summary of what this PR fixes and what's still open. I am not sure where to look for fixing the open issues, but I do think that this PR improves handling LaTeX files already substantially. From my point of view, it can be merged. Now works correctly Insertion and pair highlighting
Mismatch highlighting:
Still does not work Highlighting only shown when point on opening paren:
Backspace deletion removes too much (should only remove "(", but removes "\(")
Prefixes not detected
Tags don't work at all (neither triggers nor highlighting):
|
In my point of view, this PR can be merged. There are still some problems open with LaTeX, but the PR nevertheless fixes many of the problems regarding backslashes. |
Not sure why the checks fail; it does not seem to be related to this PR though. |
Yea, tests are failing again, I think something in cask/evm broke. I'll try to run this locally. Some additional tests for the new features would also be nice to add. |
c0ebd9d
to
440c5ab
Compare
f8151c5
to
904989d
Compare
904989d
to
31a6a7a
Compare
d05675a
to
5a83a47
Compare
5a83a47
to
f78e81c
Compare
c6b286f
to
5753795
Compare
16250a0
to
402764b
Compare
085fab2
to
02d6445
Compare
02d6445
to
452b917
Compare
Fixes the roughest issues of #784; see the discussion there.