Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore double backslashes (newlines) in Latex (#784) #792

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rgemulla
Copy link
Contributor

@rgemulla rgemulla commented Oct 3, 2017

Fixes the roughest issues of #784; see the discussion there.

@rgemulla
Copy link
Contributor Author

Here is a summary of what this PR fixes and what's still open. I am not sure where to look for fixing the open issues, but I do think that this PR improves handling LaTeX files already substantially. From my point of view, it can be merged.

Now works correctly

Insertion and pair highlighting

()
\(\)
\\()
\\\(\)
\\\(\\\)

Mismatch highlighting:

(\)
\\(\)

Still does not work

Highlighting only shown when point on opening paren:

(\\)

Backspace deletion removes too much (should only remove "(", but removes "\(")

\\(

Prefixes not detected

\emph{abc}

Tags don't work at all (neither triggers nor highlighting):

\begin{quote}
...
\end{quote}

@Fuco1 Fuco1 added this to the 1.11 milestone Nov 16, 2017
@Fuco1 Fuco1 modified the milestones: 1.11, 1.12 Dec 4, 2017
@rgemulla
Copy link
Contributor Author

In my point of view, this PR can be merged. There are still some problems open with LaTeX, but the PR nevertheless fixes many of the problems regarding backslashes.

@rgemulla
Copy link
Contributor Author

Not sure why the checks fail; it does not seem to be related to this PR though.

@Fuco1
Copy link
Owner

Fuco1 commented May 31, 2018

Yea, tests are failing again, I think something in cask/evm broke.

I'll try to run this locally. Some additional tests for the new features would also be nice to add.

@rgemulla rgemulla force-pushed the latex-fixes branch 2 times, most recently from c0ebd9d to 440c5ab Compare July 10, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants