Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the emulator in a container #4

Open
csharpfritz opened this issue Jan 28, 2019 · 4 comments
Open

Put the emulator in a container #4

csharpfritz opened this issue Jan 28, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@csharpfritz
Copy link
Contributor

With the emulator in a container, it would be easy to use for integration testing during CI processes

@csharpfritz csharpfritz added enhancement New feature or request help wanted Extra attention is needed labels Jan 28, 2019
@derekforeman
Copy link

Getting the emulator into a docker container seems to be the easy part. In doing this I see a few potentials with the tight coupling the emulator code has on the manifest.json.

To correct that I see a few options.

  1. Copy manifest into app directory / change config to reference local path to /app/manifest.json

  2. Mount path to manifest on local file system when running container & change config to reference that mount path in container

  3. Abstract emulator code to not be dependent on the manifest and duplicate manifest bits in emulator
    config.

  4. Some combination of 3 and 2/1.

If I've missed a potential scenario, please chime in.

I'll create the Dockerfile and update the readme with directions for points 1 and 2 above. If we want to take a different direction in the future, it can be decided then.

@csharpfritz
Copy link
Contributor Author

Oh yea, @mtheoryx (@roberttables on Twitch / Twitter) is actively working on this and I'll let him comment

@derekforeman
Copy link

Ok, I've about got it complete. Since I wasn't watching the stream I'm not sure if it meets the requirements, so I'll hold off on a PR. However, @mtheoryx, if this helps go for it, https://github.com/derekforeman/StreamDeckEmulator/tree/docker

@mtheoryx
Copy link

I'm gonna cover what I have so far on stream in a few minutes, then circle back here. I appreciate everyone's help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants