Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Backend Testing & Logic Fixes #79

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

DavideIadeluca
Copy link
Member

@DavideIadeluca DavideIadeluca commented Dec 17, 2024

Fixes #80

Changes proposed in this pull request:

  • Write backend tests
  • Fix discovered issues

Reviewers should focus on:
I'm thinking of changing the condition of lurking by removing the requirement that the last post needs to be read.

->where('discussion_user.last_read_post_number', '>=', $this->lastPostNumber - 1)

The translation of lurking Be notified of all new discussions and replies is currently kind of misleading. I would expect to receive notifications no matter if I've read previous posts in a discussion or not. Opinions?

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca DavideIadeluca self-assigned this Dec 17, 2024
@DavideIadeluca DavideIadeluca changed the title Implement Backend Testing Implement Backend Testing & Minor Fixes Jan 24, 2025
@DavideIadeluca DavideIadeluca added the bug Something isn't working label Jan 24, 2025
@DavideIadeluca DavideIadeluca changed the title Implement Backend Testing & Minor Fixes Implement Backend Testing & Logic Fixes Jan 24, 2025
@DavideIadeluca DavideIadeluca marked this pull request as ready for review January 24, 2025 11:22
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner January 24, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification sent multiple times/for each followed tag
2 participants