Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding response redirects into dio_logs #329

Merged
merged 1 commit into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/talker_dio_logger/lib/dio_logs.dart
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ class DioResponseLog extends TalkerLog {
final responseMessage = response.statusMessage;
final data = response.data;
final headers = response.headers.map;
final redirects = response.redirects;

msg += '\nStatus: ${response.statusCode}';

Expand All @@ -98,6 +99,13 @@ class DioResponseLog extends TalkerLog {
final prettyHeaders = _encoder.convert(headers);
msg += '\nHeaders: $prettyHeaders';
}

if (settings.printResponseRedirects && redirects.isNotEmpty) {
final prettyRedirects = redirects.map((redirect) {
return '[${redirect.statusCode} ${redirect.method} - ${redirect.location}]';
}).join('\n');
msg += '\nRedirects:\n$prettyRedirects';
}
} catch (_) {
// TODO: add handling can`t convert
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class TalkerDioLoggerSettings {
this.printResponseData = true,
this.printResponseHeaders = false,
this.printResponseMessage = true,
this.printResponseRedirects = false,
this.printErrorData = true,
this.printErrorHeaders = true,
this.printErrorMessage = true,
Expand All @@ -34,6 +35,9 @@ class TalkerDioLoggerSettings {
/// Print [response.statusMessage] if true
final bool printResponseMessage;

/// Print [response.redirects] if true
final bool printResponseRedirects;

/// Print [error.response.data] if true
final bool printErrorData;

Expand Down
51 changes: 51 additions & 0 deletions packages/talker_dio_logger/test/logs_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,57 @@ void main() {
result, contains('Headers: {\n "Authorization": "Bearer Token"\n}'));
});

test(
'generateTextMessage should include redirects if printResponseRedirects is true',
() {
final requestOptions = RequestOptions(
path: '/test',
method: 'GET',
);
final settings = TalkerDioLoggerSettings(printResponseRedirects: true);
final dioRequestLog = DioResponseLog(
'Test message',
response: Response(
requestOptions: requestOptions,
redirects: [
RedirectRecord(200, 'GET', Uri.parse('about:blank')),
RedirectRecord(200, 'POST', Uri.parse('about:blank')),
],
),
settings: settings,
);

final result = dioRequestLog.generateTextMessage();

expect(
result,
contains(
'Redirects:\n[200 GET - about:blank]\n[200 POST - about:blank]'));
});

test(
'generateTextMessage should not include redirects if printResponseRedirects is false',
() {
final requestOptions = RequestOptions(
path: '/test',
method: 'GET',
);
final settings = TalkerDioLoggerSettings(printResponseRedirects: false);
final dioRequestLog = DioResponseLog(
'Test message',
response: Response(
requestOptions: requestOptions,
redirects: [
RedirectRecord(200, 'GET', Uri.parse('about:blank')),
],
),
settings: settings,
);

final result = dioRequestLog.generateTextMessage();
expect(result.contains('Redirects:'), isFalse);
});

// Add more tests for DioRequestLog as needed
});

Expand Down