[menu] Added a new filter for enabling the advanced CPT-related menu … #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieleAlessandra
requested changes
Jan 8, 2025
| 'admin.php'; | ||
|
|
||
| if ( fs_apply_filter( $this->_module_unique_affix, 'enable_cpt_advanced_menu_logic', false ) ) { | ||
| $parent_slug = 'admin.php'; |
There was a problem hiding this comment.
Why do we need to re-define $parent_slug here? it has just been defined on line 703.
There was a problem hiding this comment.
@DanieleAlessandra The line above preserves the original behavior when the new filter is not used. When the filter is applied, the behavior changes slightly, and not using admin.php may lead to unexpected issues.
| $menu['parent_slug'] : | ||
| 'admin.php'; | ||
|
|
||
| if ( fs_apply_filter( $this->_module_unique_affix, 'enable_cpt_advanced_menu_logic', false ) ) { |
There was a problem hiding this comment.
Do we have documentation about enable_cpt_advanced_menu_logic hook somewhere?
There was a problem hiding this comment.
@DanieleAlessandra This will be documented. Thanks!
DanieleAlessandra
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…logic.