Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISRA C 2012 deviations #190

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

chinglee-iot
Copy link
Member

Description

  • Fix rule 18.4 deviations. Not using operators with pointer type.
  • Suppress rule 20.5 deviations in misra.config to allow use of undef.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (640dd3f) 94.02% compared to head (b039d06) 94.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files           3        3           
  Lines        1690     1690           
  Branches      442      442           
=======================================
  Hits         1589     1589           
  Misses         17       17           
  Partials       84       84           
Flag Coverage Δ
unit_tests 94.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Fix rule 18.4 deviations. Not using operators with pointer type.
* Suppress rule 20.5 deviations in misra.config to allow use of undef.
@Skptak
Copy link
Member

Skptak commented Feb 22, 2024

Will this repo need the same change to the CI build as coreMQTT's ci.yml file?

Will it also need its unit test version bumped up as was done in coreMQTT/test/CMakeList.txt?

@chinglee-iot
Copy link
Member Author

This project already defined UINT_TESTS and COVERITY option in test/CMakeLists.txt. Another PR will be created to align the test/CMakeLists.txt.

@chinglee-iot chinglee-iot merged commit e0cd4db into FreeRTOS:main Feb 26, 2024
14 checks passed
@chinglee-iot chinglee-iot deleted the fix-misra-deviations branch February 26, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants