Pass core ID to port lock macros

[felixvanoost]

Description

Passes the core ID as an argument to the SMP lock macros port{GET/RELEASE}_{TASK/ISR}_LOCK in tasks.c. Since #1206, the functions calling these macros keep track of the core ID, so the port-specific spinlock function implementations can eliminate their internal calls to portGET_CORE_ID() to reduce the number of unnecessary, and generally slow, accesses to a peripheral register. This benefits the following FreeRTOS functions:

Function	# of eliminated calls to portGET_CORE_ID()
prvCheckForRunStateChange()	5
vTaskSwitchContext()	4
vTaskEnterCritical()	2
vTaskEnterCriticalFromISR()	1
vTaskExitCritical()	2
vTaskExitCriticalFromISR()	1

I've updated the spinlock definitions for two of the three SMP-compatible ports (F1Kx and RP2040). The XCOREAI port spinlocks are implemented elsewhere in their toolchain so I've just cast the new argument to void.

Test Steps

Timing analysis coming shortly.

Checklist:

• I have tested my changes. No regression in existing tests.
• I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

Closes #1204

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[jasonpcarroll]

Hi @felixvanoost - sorry for the late response. This looks great! I am going to ping someone with a bit more familiarity with SMP implementation to also take a look. The unit tests will need to be updated, but to save your time, I would wait on the other reviewer before updating them.

Best,

Jason Carroll

[chinglee-iot]

I have verified this change with the unit test PR, and it works without issues. The PR can be found at FreeRTOS/FreeRTOS#1319.

Please note that this change is not backward compatible. Since all TASK and ISR spinlock port macros need to be implemented recursively, it makes sense to add the xCoreID parameter to these macros.

We should proceed to update the following ports for the port macros change:

portable/ThirdParty/Community-Supported-Ports/GCC/CORTEX_A53_64-bit_UltraScale_MPSoC/portmacro.h
portable/ThirdParty/Community-Supported-Ports/GCC/RP2350_ARM_NTZ/non_secure/portmacro.h
portable/ThirdParty/Community-Supported-Ports/GCC/RP2350_RISC-V/include/portmacro.h
portable/ThirdParty/Partner-Supported-Ports/TI/CORTEX_A53_64-BIT_TI_AM64_SMP/portmacro.h

[felixvanoost]

I have verified this change with the unit test PR, and it works without issues. The PR can be found at FreeRTOS/FreeRTOS#1319.

Please note that this change is not backward compatible. Since all TASK and ISR spinlock port macros need to be implemented recursively, it makes sense to add the xCoreID parameter to these macros.

We should proceed to update the following ports for the port macros change:

portable/ThirdParty/Community-Supported-Ports/GCC/CORTEX_A53_64-bit_UltraScale_MPSoC/portmacro.h
portable/ThirdParty/Community-Supported-Ports/GCC/RP2350_ARM_NTZ/non_secure/portmacro.h
portable/ThirdParty/Community-Supported-Ports/GCC/RP2350_RISC-V/include/portmacro.h
portable/ThirdParty/Partner-Supported-Ports/TI/CORTEX_A53_64-BIT_TI_AM64_SMP/portmacro.h

@chinglee-iot I've created PRs in both repos with the corresponding changes. :)

[jasonpcarroll]

Sorry could you fix the CMock unit tests?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[aggarg]

Sorry could you fix the CMock unit tests?

@chinglee-iot addressed unit tests in this PR - FreeRTOS/FreeRTOS#1319.

Requested changes has been done.

[aggarg]

@felixvanoost Thank you for your contribution!