Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround from #248 that has since been fixed in upstream usethis package #259

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

slager
Copy link
Contributor

@slager slager commented Jan 28, 2025

Description

Simplifies the VISCtemplates codebase. The workaround from #248 is no longer needed, since this has been corrected in the latest usethis release.

  • This PR includes unit tests
  • This PR establishes a new function or updates parameters in an existing function
    • The roxygen skeleton for this function has been updated using devtools::document
  • I have updated NEWS.md to describe the proposed changes

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (1d6c207) to head (dd75894).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #259      +/-   ##
===========================================
- Coverage    82.10%   81.79%   -0.32%     
===========================================
  Files            8        8              
  Lines          352      346       -6     
===========================================
- Hits           289      283       -6     
  Misses          63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slager slager marked this pull request as draft January 28, 2025 17:25
@slager
Copy link
Contributor Author

slager commented Jan 28, 2025

Will look into why Hmisc is no longer installing on 'statsrv' CI. Does not appear to be related to this specific PR.

@slager slager marked this pull request as ready for review January 31, 2025 22:35
@slager slager merged commit cdf41f6 into develop Jan 31, 2025
8 checks passed
@slager slager deleted the revert_usethis_fix branch January 31, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants