fix: review comments

FreakyAli · Dec 13, 2024 · 55beb31 · 55beb31
1 parent e7c4492
commit 55beb31
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 17 deletions.
diff --git a/Plugin.Maui.Biometric/Plugin.Maui.Biometric/Platforms/Android/BiometricService.android.cs b/Plugin.Maui.Biometric/Plugin.Maui.Biometric/Platforms/Android/BiometricService.android.cs
@@ -106,7 +106,7 @@ public partial Task<BiometricType[]> GetEnrolledBiometricTypesAsync()
             if(canAuthenticate == BiometricManager.BiometricErrorNoneEnrolled)
             {
                 availableOptions[0] = BiometricType.None;
-                availableOptions[0] = BiometricType.None;
+                availableOptions[1] = BiometricType.None;
             }
             if (canAuthenticate == BiometricManager.BiometricSuccess)
             {
@@ -129,8 +129,6 @@ public partial Task<BiometricType[]> GetEnrolledBiometricTypesAsync()
                     availableOptions[1] = BiometricType.None;
                 }
             }
-            Debug.WriteLine(availableOptions[0]);
-            Debug.WriteLine(availableOptions[1]);
         }
         return Task.FromResult(availableOptions);
     }

diff --git a/Plugin.Maui.Biometric/Plugin.Maui.Biometric/Platforms/iOS/BiometricService.ios.cs b/Plugin.Maui.Biometric/Plugin.Maui.Biometric/Platforms/iOS/BiometricService.ios.cs
@@ -44,23 +44,16 @@ public async partial Task<AuthenticationResponse> AuthenticateAsync(Authenticati
     public partial Task<BiometricType[]> GetEnrolledBiometricTypesAsync()
     {
         var localAuthContext = new LAContext();
-        var availableOptions = new BiometricType[2];
+        var availableOptions = new BiometricType[2] { BiometricType.None, BiometricType.None };
         if (localAuthContext.CanEvaluatePolicy(LAPolicy.DeviceOwnerAuthenticationWithBiometrics, out var _))
         {
             var isFace = localAuthContext.BiometryType == LABiometryType.FaceId;
             var isFingerprint = localAuthContext.BiometryType == LABiometryType.TouchId;
-            if (isFace)
-            {
-                availableOptions[0] = (BiometricType.Face);
-            }
-            if (isFingerprint)
-            {
-                availableOptions[1] = (BiometricType.Fingerprint);
-            }
-            if (!isFace && !isFingerprint)
+
+            if (isFace || isFingerprint)
             {
-                availableOptions[0] = (BiometricType.None);
-                availableOptions[1] = (BiometricType.None);
+                availableOptions[0] = isFace ? BiometricType.Face : BiometricType.None;
+                availableOptions[1] = isFingerprint ? BiometricType.Fingerprint : BiometricType.None;
             }
         }
         return Task.FromResult(availableOptions);

diff --git a/Plugin.Maui.Biometric/Samples/MainPage.xaml.cs b/Plugin.Maui.Biometric/Samples/MainPage.xaml.cs
@@ -1,4 +1,5 @@
-using Plugin.Maui.Biometric;
+using System.Diagnostics;
+using Plugin.Maui.Biometric;
 
 namespace Samples;
 
@@ -16,7 +17,10 @@ private async void OnCounterClicked(object sender, EventArgs e)
     {
         //get a list of enrolled biometric types
         var enrolledTypes = await biometric.GetEnrolledBiometricTypesAsync();
-
+        foreach(var item in enrolledTypes)
+        {
+            Console.WriteLine(item.ToString());
+        }
         //get current status of the hardware
         var result = await biometric.GetAuthenticationStatusAsync(AuthenticatorStrength.Weak);
         if (result == BiometricHwStatus.Success)