FreakySwitch: Added customization options for animation duration, thumb size in the… #165
Conversation
… off state, and a check mark in the on state.
WalkthroughThe pull request introduces significant enhancements to the Changes
Sequence DiagramsequenceDiagram
participant Developer
participant FreakySwitch
participant Renderer
Developer->>FreakySwitch: Set custom properties
FreakySwitch->>Renderer: Configure animation duration
FreakySwitch->>Renderer: Adjust thumb size
FreakySwitch->>Renderer: Render checkmark (optional)
Renderer-->>Developer: Updated switch control
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs (3)
54-58: Consider improving the animation duration validation.While the safety check for non-positive values is good, consider:
- Setting a reasonable minimum duration (e.g., 16ms for 60fps) for smooth animations
- Adding an upper bound to prevent extremely long animations
- if (durationInSeconds <= 0) - { - durationInSeconds = 0.001d; - } + const double MIN_DURATION_SECONDS = 0.016; // 16ms minimum for 60fps + const double MAX_DURATION_SECONDS = 1.0; // 1 second maximum + durationInSeconds = Math.Clamp(durationInSeconds, MIN_DURATION_SECONDS, MAX_DURATION_SECONDS);
189-205: LGTM! Well-implemented check mark drawing with proper scaling.The check mark is correctly positioned relative to the thumb size, ensuring proper scaling across different switch sizes.
Add parentheses to clarify arithmetic precedence.
To improve code clarity, add parentheses around arithmetic expressions.
- checkmarkPath.MoveTo(thumbLeft + thumbWidth * 0.25f, thumbTop + thumbWidth * 0.5f); - checkmarkPath.LineTo(thumbLeft + thumbWidth * 0.45f, thumbTop + thumbWidth * 0.7f); - checkmarkPath.LineTo(thumbLeft + thumbWidth * 0.75f, thumbTop + thumbWidth * 0.3f); + checkmarkPath.MoveTo(thumbLeft + (thumbWidth * 0.25f), thumbTop + (thumbWidth * 0.5f)); + checkmarkPath.LineTo(thumbLeft + (thumbWidth * 0.45f), thumbTop + (thumbWidth * 0.7f)); + checkmarkPath.LineTo(thumbLeft + (thumbWidth * 0.75f), thumbTop + (thumbWidth * 0.3f));🧰 Tools
🪛 GitHub Check: CodeFactor
[notice] 193-193: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L193
Arithmetic expressions should declare precedence. (SA1407)
[notice] 195-195: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L195
Arithmetic expressions should declare precedence. (SA1407)
[notice] 194-194: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L194
Arithmetic expressions should declare precedence. (SA1407)
[notice] 193-193: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L193
Arithmetic expressions should declare precedence. (SA1407)
[notice] 194-194: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L194
Arithmetic expressions should declare precedence. (SA1407)
[notice] 195-195: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L195
Arithmetic expressions should declare precedence. (SA1407)
Line range hint
226-233: Consider tightening the thumb size factor validation.While the current validation ensures the factor is between 0 and 1, consider:
- Excluding 0 as it would make the thumb invisible
- Setting a minimum size factor (e.g., 0.2) to maintain usability
- if (ThumbOffSizeFactor > 0 && ThumbOffSizeFactor < 1) + const float MIN_THUMB_SIZE_FACTOR = 0.2f; + if (ThumbOffSizeFactor >= MIN_THUMB_SIZE_FACTOR && ThumbOffSizeFactor < 1)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs(8 hunks)
🧰 Additional context used
🪛 GitHub Check: CodeFactor
MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs
[notice] 193-193: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L193
Arithmetic expressions should declare precedence. (SA1407)
[notice] 195-195: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L195
Arithmetic expressions should declare precedence. (SA1407)
[notice] 194-194: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L194
Arithmetic expressions should declare precedence. (SA1407)
[notice] 193-193: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L193
Arithmetic expressions should declare precedence. (SA1407)
[notice] 194-194: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L194
Arithmetic expressions should declare precedence. (SA1407)
[notice] 195-195: MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs#L195
Arithmetic expressions should declare precedence. (SA1407)
🔇 Additional comments (2)
MAUI.FreakyControls/MAUI.FreakyControls/FreakySwitch/FreakySwitch.cs (2)
17-21: LGTM! Well-chosen default values for the new customization options.The default values are sensible and maintain platform-specific behavior where appropriate.
Line range hint
255-381: LGTM! Well-implemented bindable properties following MAUI conventions.The new properties are correctly implemented with appropriate types and default values, maintaining consistency with the static fields.
sferhah
changed the title
Added customization options for: animation duration, thumb size in the off state, and a check mark in the on state. Example of use:
Summary by CodeRabbit
New Features
Improvements