fix: Remove pygit2 dependency #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpelsepp
force-pushed
the
pygit
branch
2 times, most recently
from
dcddf58 to
d0781e2
Compare
On a few platforms (ask @peckto) the pygit2 dependency cannot be installed with poetry, since the toolchain tries to build from source and fails. Since we only use this library to detect the git root, let's implement this with calling the Git binary instead. When git is not available, then Git repos are not used for config discovery.
peckto
approved these changes
Aug 26, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a few platforms (ask @peckto) the pygit2 dependency cannot be
installed with poetry, since the toolchain tries to build from source
and fails. Since we only use this library to detect the git root, let's
implement this with calling the Git binary instead. When git is not available,
then Git repos are not used for config discovery.