Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation review. #50

Merged
merged 1 commit into from
Nov 25, 2016
Merged

French translation review. #50

merged 1 commit into from
Nov 25, 2016

Conversation

trebmuh
Copy link
Contributor

@trebmuh trebmuh commented Nov 24, 2016

Following #38 (comment) advice. Hope that helps.
@aroomthedoomed : You're translation was really good! I've been making some changes/fixes. I hope that helps you. Feel free to comment those changes.

@trebmuh
Copy link
Contributor Author

trebmuh commented Nov 24, 2016

Please note that I wasn't able to test a build of it since I'm running a Debian Jessie and it's not supported reading at https://github.com/FrancescoCeruti/linux-show-player/releases

@aroom
Copy link

aroom commented Nov 25, 2016

@trebmuh thanks for the corrections. it's a lot more accurate now.

but it seems like they are other files the reviews, like :

/lisp/modules/action_cues/i18n/action_cues_fr.ts
/lisp/modules/gst_backend/i18n/gst_backend_fr.ts
/lisp/modules/media_info/i18n/media_info_fr.ts
/lisp/modules/midi/i18n/midi_fr.ts
/lisp/modules/replay_gain/i18n/replay_gain_fr.ts
/lisp/modules/uri_changer/i18n/uri_changer_fr.ts

/lisp/plugins/controller/i18n/controller_fr.ts
/lisp/plugins/synchronizer/i18n/synchronizer_fr.ts
/lisp/plugins/triggers/i18n/triggers_fr.ts

they are a lot shorter though ;)

@trebmuh
Copy link
Contributor Author

trebmuh commented Nov 25, 2016

To @FrancescoCeruti and @aroomthedoomed : done.
Hope that helps.

@FrancescoCeruti : I hope I didn't messed up with the second part since I was expecting the PR to join here, but it does look that it's a new PR. If you need another PR, just let me know. If you can cope with these 2 PR, then it's even better! :)

@FrancescoCeruti
Copy link
Owner

@trebmuh don't worry ;)

@FrancescoCeruti FrancescoCeruti merged commit 087f306 into FrancescoCeruti:french_review_1 Nov 25, 2016
@trebmuh
Copy link
Contributor Author

trebmuh commented Nov 25, 2016

👍

@trebmuh trebmuh deleted the patch-1 branch November 25, 2016 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants