Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut for cue (issue #158) #172

Closed
wants to merge 4 commits into from

Conversation

Gajenthran
Copy link
Contributor

@Gajenthran Gajenthran commented May 5, 2019

As I said on the title, I add shortcut for cues (issues #158 and #160) with QKeySequenceEdit. I have not changed a lot of things : I replace the QLineEdit with QKeySequenceEdit for the first column, to have a variety of commands. Then I modified a little bit the key_pressed function in keyboard.py to include QKeySequence.

Hope it will help you !

@FrancescoCeruti
Copy link
Owner

FrancescoCeruti commented May 7, 2019

Thanks 😄

I've tested the solution but unfortunately the QKeySequenceEdit is a bit inadequate 🙁

  • The widget allow to insert multiple values, this is not supported by the plugin
  • Some keys (or combinations) cannot be entered because are intercepted elsewhere (e.g. Esc , Tab , Enter) to navigate the widgets (e.g. Esc close the editor)

I've already implemented a solution using a custom widget that provide an alternative way to insert the mentioned keys, I'll push it when at home.

@Gajenthran
Copy link
Contributor Author

I saw it (I had a little problem with the List Layout but I saw the issue about that).

Some keys (or combinations) cannot be entered because are intercepted elsewhere (e.g. Esc , Tab , Enter) to navigate the widgets (e.g. Esc close the editor)

I forgot that point.
Don't you think we should also do for Selection Mode ? For example if I had a new shortcut with UP arrow, it will allow my shortcut and the action for the selection Mode and will potentially create conflict.

I put some lines to avoid that kind of conflict in layout.py, you can check it if you want.

@fnetX fnetX mentioned this pull request May 10, 2019
@Gajenthran
Copy link
Contributor Author

Gajenthran commented May 11, 2019

Instead of creating a new pull request, I put it in this. I add more features to shorten (editing and removing) in the list. I felt that it was not necessary to create new pull request because it's minor changement in the code.

Hope it will help you !

@FrancescoCeruti FrancescoCeruti self-assigned this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants