Add "Number of items" string to strings.xml #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you think "Sort by number of items" sounds more user friendly than "Sort by quantity"? I think it should be "Number of items". |
Yes, my bad! My thoughts were based on the title of the issue — #379. I've updated the string and also changed the 'sort by' constant. The final result will be |
terofeev
changed the title
naveensingh
reviewed
Mar 3, 2025
Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
"Number of items"tostrings.xml.SORT_BY_QUANTITYtoSORT_BY_COUNTFixes the following issue(s)
Acknowledgement