Test validation and robustness of grading vars #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippImhof
added
the
tests
PhilippImhof
force-pushed
the
gradingvars-validation
branch
from
8acb986 to
e007c42
Compare
PhilippImhof
force-pushed
the
gradingvars-validation
branch
from
e007c42 to
6a9a84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem outlined in #122 shows that teachers might accidentally create risky a grading criterion. They might also do the same in the grading vars, e.g. using
testvar = _0/_1;.This PR adds a unit test to make sure invalidated grading vars do not break a question. Also, while fixing the issue in #122, I realized that we do not verify the validation of the grading vars in the edit form actually works. Therefore, this PR adds a behat test.