fix: make sure VictoryPortal id does not change between re-renders (#…

…2929)
FormidableLabs · Oct 24, 2024 · 5e94c61 · 5e94c61
1 parent 8f2804f
commit 5e94c61
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/four-melons-divide.md b/.changeset/four-melons-divide.md
@@ -0,0 +1,5 @@
+---
+"victory-core": minor
+---
+
+Fix VictoryPortal id changing for every render
diff --git a/packages/victory-core/src/victory-portal/victory-portal.tsx b/packages/victory-core/src/victory-portal/victory-portal.tsx
@@ -1,4 +1,4 @@
-import React from "react";
+import React, { useState } from "react";
 import { defaults, uniqueId } from "lodash";
 import * as Log from "../victory-util/log";
 import * as Helpers from "../victory-util/helpers";
@@ -15,7 +15,7 @@ const defaultProps: Partial<VictoryPortalProps> = {
 
 export const VictoryPortal = (initialProps: VictoryPortalProps) => {
   const props = { ...defaultProps, ...initialProps };
-  const id = uniqueId();
+  const [id] = useState(uniqueId());
   const portalContext = usePortalContext();
 
   if (!portalContext) {