-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove-project-json #495
base: develop
Are you sure you want to change the base?
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 02779e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
c1eb1c3
to
5384b59
Compare
changes outputs for e2e suites to be in .playwright of project root updates dynamic changesets to save ci computation update eslint ignore files
5384b59
to
0b50409
Compare
This removes all instances of a project.json file. This is just for demonstration purposes. This type of setup uses `nx` more as a background task and uses `pnpm` to execute scripts. Its not very different than the existing setup the core difference is you must reference a project based on the name in its `package.json` file rather than the short-name that the project.json defined.
c57f3d6
to
b33bc2f
Compare
b33bc2f
to
eb4d9e7
Compare
eb4d9e7
to
013165d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #495 +/- ##
===========================================
- Coverage 57.24% 56.38% -0.87%
===========================================
Files 123 22 -101
Lines 26966 2476 -24490
Branches 1717 91 -1626
===========================================
- Hits 15438 1396 -14042
+ Misses 11528 1080 -10448 ☔ View full report in Codecov by Sentry. |
This is more along the lines of what I intend to push to the new repo.
This removes all instances of a project.json file, except for the root one. This is just for demonstration purposes. This type of setup uses
nx
more as a background taskand uses
pnpm
to execute scripts. Itsnot very different than the existing setup
the core difference is you must reference
a project based on the name in its
package.json
file rather than the short-namethat the project.json defined.
I left the root project.json in because the
nx
executor does some nice things for spawning verdaccio and modifying the .npmrc file for you so your npm points to verdaccio when its running and tries to clean it up when you exit.Why may we want this setup
Well - this is basically what a
pnpm
monorepo will look like. Its just usingnpm scripts
instead ofnx
executors.nx
is just in the background for CI and task organizationI still use
nx
to run commands because I did not setup the repo forpnpm
to do that.But this makes it easier to rip out nx if we want to at some point. So i figured i'd djust present this idea to see how it looks and make sure everything worked.
package generator
This includes a package generator now available when calling
pnpm create-package
. It has a small walkthrough of prompts, and will create a package in thepackages
directory.JIRA Ticket
Please link jira ticket here
Description
Type of Change
Please Delete options that are not relevant
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Definition of Done
Check all that apply
Documentation