Bevy 0.15

[Bendzae]

Pretty straight forward upgrade. Notable changes that impact this project are:

• Handle is not a component anymore so I needed to introduce wrapper components
• Have to use RenderEntity in extaction now
• RenderVisibleEntities to get visible RenderEntitiy MainEntity pairs
• Examples now all use required component approach instead of bundles

Everything seems to work but I tried to keep the effort as small as possible.
Should probably migrate to required components instead of bundles.

Let me know if you would like any changes :)

[fslabs-bot]

Welcome @Bendzae! It looks like this is your first PR to ForesightMiningSoftwareCorporation/bevy_polyline 🎉

[nsabovic]

I have no authority on the topic but it would be easier to use if the API mimics Mesh3d and Mesh3dMaterial:

#[require(Transform, Visibility)]
pub struct Mesh3d(pub Handle<Mesh>);

So just PolylineHandle would require Transform and Visibility which would produce GlobalTransform, InheritedVisibility and ViewVisibility.

Mesh3d does not require Mesh3dMaterials but won't render unless it has a material, so that's probably what PolylineMaterialHandle should copy.

[Bendzae]

I have no authority on the topic but it would be easier to use if the API mimics Mesh3d and Mesh3dMaterial:

#[require(Transform, Visibility)]
pub struct Mesh3d(pub Handle<Mesh>);

So just PolylineHandle would require Transform and Visibility which would produce GlobalTransform, InheritedVisibility and ViewVisibility.

Mesh3d does not require Mesh3dMaterials but won't render unless it has a material, so that's probably what PolylineMaterialHandle should copy.

I agree but I wanted to keep the changes as minimal as possible because I don't know if the authors might want to keep the bundle worklfow. Happy to implement the required component approach once I know if it is preferred.

[IceSentry]

Hey, sorry for keeping you waiting so long. Everything looks good to me and yeah I prefer keeping it like this for now.

[fslabs-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IceSentry

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment