Skip to content

Commit

Permalink
updated to v0.1.42
Browse files Browse the repository at this point in the history
  • Loading branch information
mpdougherty committed Jan 25, 2023
1 parent 633f8ac commit 56e95a6
Show file tree
Hide file tree
Showing 8 changed files with 92 additions and 34 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: fluvgeo
Title: A Package for Fluvial Geomorphic Analysis
Version: 0.1.38
Version: 0.1.42
Authors@R: c(
person("Michael", "Dougherty",
email = "Michael.P.Dougherty@usace.army.mil",
Expand Down
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@ export(metric_colors)
export(planform)
export(planform_dimensions)
export(reach_rhg_graph)
export(sf2arc)
export(shear_stress)
export(slope_sinuosity)
export(sp2arc)
export(stream_power)
export(sx2arc_table)
export(xs2pts)
export(xs_compare_plot_L1)
export(xs_compare_plot_L2)
Expand Down
17 changes: 17 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
# fluvgeo v0.1.42 (2023-01-21)

## Major changes
* Added the `sx2arc_table` function to write `sf` and `sp` objects to a file geodatabase table.

## Bug Fixes
* Discovered that `arcgisbinding::arc.write` frequently fails writing feature classes to a geodatabase. "Wild caught" file geodatabase feature classes produced by the `FluvialGeomorph-toolbox` when converted to `sp` or `sf` inside `fluvgeo` frequently fail to create a valid feature class (i.e., missing geometry, no coordinate system) when saved to a file geodatabase using `arc.write`.
* This behavior is described in the `arcgisbinding` issues listed below. These outstanding issues identify and generally discuss the problems, but provide no fix or clear workaround guidance.

- [Issue 108](https://github.com/R-ArcGIS/r-bridge-install/issues/108)
- [Issue 38](https://github.com/R-ArcGIS/r-bridge/issues/38)

* The workarounds identified in these issues were implemented in the `sp2arc` and `sf2arc` functions. No combination of these suggestions were able to produce a reliable workaround.
* Since no comprehensive solution is currently being provided for these issues in `arc.write`, we have chosen to minimize our exposure. We have decided to only write table data back to the file geodatabase.
* If the `arcgisbinging` team addresses these issues, we may choose to go back to trusting the writing of file geodatabase feature classes using `arc.write`.


# fluvgeo v0.1.38 (2023-01-21)

## Bug Fixes
Expand Down
3 changes: 1 addition & 2 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ An `R` Package for Performing **Fluv**ial **Geo**mrphology Analysis
## Package Status
[![Maturing](https://img.shields.io/badge/lifecycle-maturing-blue.svg)](https://www.tidyverse.org/lifecycle)
[![Project Status: Active The project has reached a stable, usable state and is being actively developed.](https://www.repostatus.org/badges/latest/active.svg)](https://www.repostatus.org/#active)
[![packageversion](https://img.shields.io/badge/Package%20version-0.1.38-orange.svg?style=flat-square)](commits/master)
[![packageversion](https://img.shields.io/badge/Package%20version-0.1.42-orange.svg?style=flat-square)](commits/master)
[![Last-changedate](https://img.shields.io/badge/last%20change-`r gsub('-', '--', Sys.Date())`-yellowgreen.svg)](/commits/master)
[![Licence](https://img.shields.io/badge/licence-CC0-blue.svg)](http://choosealicense.com/licenses/cc0-1.0/)

Expand Down Expand Up @@ -53,7 +53,6 @@ Check out the [NEWS](NEWS.md) for details on the latest updates.
* Michael Dougherty, Geographer, U.S. Army Corps of Engineers
<div itemscope itemtype="https://schema.org/Person"><a itemprop="sameAs" content="https://orcid.org/0000-0002-1465-5927" href="https://orcid.org/0000-0002-1465-5927" target="orcid.widget" rel="me noopener noreferrer" style="vertical-align:top;"><img src="https://orcid.org/sites/default/files/images/orcid_16x16.png" style="width:1em;margin-right:.5em;" alt="ORCID iD icon">https://orcid.org/0000-0002-1465-5927</a></div>
* Christopher Haring, Fluvial Geomorphologist/Research Physical Scientist, U.S. Army Corps of Engineers
* Charles Theiling, Ecologist, U.S. Army Corps of Engineers

## Install
To install the `fluvgeo` package, install from GitHub using the `devtools` package:
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ An `R` Package for Performing **Fluv**ial **Geo**mrphology Analysis
[![Project Status: Active The project has reached a stable, usable state
and is being actively
developed.](https://www.repostatus.org/badges/latest/active.svg)](https://www.repostatus.org/#active)
[![packageversion](https://img.shields.io/badge/Package%20version-0.1.38-orange.svg?style=flat-square)](commits/master)
[![Last-changedate](https://img.shields.io/badge/last%20change-2023--01--21-yellowgreen.svg)](/commits/master)
[![packageversion](https://img.shields.io/badge/Package%20version-0.1.42-orange.svg?style=flat-square)](commits/master)
[![Last-changedate](https://img.shields.io/badge/last%20change-2023--01--25-yellowgreen.svg)](/commits/master)
[![Licence](https://img.shields.io/badge/licence-CC0-blue.svg)](http://choosealicense.com/licenses/cc0-1.0/)

## Description
Expand Down Expand Up @@ -66,7 +66,6 @@ Check out the [NEWS](NEWS.md) for details on the latest updates.
<a itemprop="sameAs" content="https://orcid.org/0000-0002-1465-5927" href="https://orcid.org/0000-0002-1465-5927" target="orcid.widget" rel="me noopener noreferrer" style="vertical-align:top;"><img src="https://orcid.org/sites/default/files/images/orcid_16x16.png" style="width:1em;margin-right:.5em;" alt="ORCID iD icon">https://orcid.org/0000-0002-1465-5927</a>
- Christopher Haring, Fluvial Geomorphologist/Research Physical
Scientist, U.S. Army Corps of Engineers
- Charles Theiling, Ecologist, U.S. Army Corps of Engineers

## Install

Expand Down
39 changes: 39 additions & 0 deletions man/sf2arc.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 9 additions & 28 deletions man/sp2arc.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions man/sx2arc_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 56e95a6

Please sign in to comment.