Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FF Auth on Remote Instances #5014

Closed
2 of 4 tasks
joepavitt opened this issue Jan 15, 2025 · 9 comments
Closed
2 of 4 tasks

Support FF Auth on Remote Instances #5014

joepavitt opened this issue Jan 15, 2025 · 9 comments
Assignees
Labels
customer request requested by customer feature-request New feature or request that needs to be turned into Epic/Story details headline Something to highlight in the release sales request requested by a sales lead size:L - 5 Sizing estimation point
Milestone

Comments

@joepavitt
Copy link
Contributor

joepavitt commented Jan 15, 2025

Description

We support FF User auth for Hosted Instances, but not Remote. This had been avoided originally because we cannot guarantee that Remote Instances are running in an online environment, given many customers run in closed/offline environments.

However, if customers want to use FF Auth, then we should not stop them. There is value, especially in use cases with FlowFuse Dashboard, to have FF User Auth enabled and securing remote Dashboards, especially when paired with the FF User Plugin.

Which customers would this be available to

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

Tasks

Preview Give feedback
@joepavitt joepavitt added feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do customer request requested by customer sales request requested by a sales lead labels Jan 15, 2025
@joepavitt joepavitt added this to the 2.14 milestone Jan 15, 2025
@joepavitt joepavitt added headline Something to highlight in the release size:L - 5 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Jan 15, 2025
@joepavitt joepavitt moved this to Scheduled in ☁️ Product Planning Jan 15, 2025
@joepavitt joepavitt moved this to Todo in 🛠 Development Jan 15, 2025
@joepavitt joepavitt moved this from Todo to Up Next in 🛠 Development Jan 17, 2025
@knolleary knolleary self-assigned this Jan 24, 2025
@knolleary knolleary moved this from Up Next to In Progress in 🛠 Development Jan 24, 2025
@knolleary knolleary moved this from In Progress to Review in 🛠 Development Feb 3, 2025
@joepavitt
Copy link
Contributor Author

Status - both #5068 and FlowFuse/device-agent#341 are ready to merge, just need to coordinate.

@knolleary is this something we can do today?

@knolleary
Copy link
Member

@joepavitt the device agent PR has been merged. We are not ready to cut the release as I want to see if we can get #5069 included as a significant DX improvement. I'm looking at that today.

Once the release is cut, we can then merge #5068 and have it go live.

@joepavitt
Copy link
Contributor Author

Thanks Nick

@hardillb hardillb moved this from Review to Needs Verification in 🛠 Development Feb 12, 2025
@joepavitt
Copy link
Contributor Author

@hardillb are you okay to verify this please so that we can close it out?

@hardillb
Copy link
Contributor

I'll try and set up a device on prod this afternoon and verify.

I did test it all locally as part of the review, so should be good.

@knolleary
Copy link
Member

Issue reported by customer: https://app-eu1.hubspot.com/help-desk/26586079/view/233410279/ticket/88305701084/thread/10233611463#email

If the device's local access is via http, but the platform is https, the platform redirects back to https on the device which doesn't work.

Need to check the referrer origin on the request to ensure it is applied when redirecting.

@hardillb
Copy link
Contributor

I've just tested on prod and the final redirect got the HTTP vs HTTPS wrong (the redirect was to https://localhost:1880 not http://localhost:1880

@knolleary
Copy link
Member

Fix for http/https issue in FlowFuse/device-agent#353

Once that is merged and we cut the 3.1.2 release of Device Agent, we can verify and close this issue.

@hardillb
Copy link
Contributor

I have verified this with 3.1.2 and production.

@github-project-automation github-project-automation bot moved this from Scheduled to Closed / Done in ☁️ Product Planning Feb 14, 2025
@github-project-automation github-project-automation bot moved this from Needs Verification to Done in 🛠 Development Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer request requested by customer feature-request New feature or request that needs to be turned into Epic/Story details headline Something to highlight in the release sales request requested by a sales lead size:L - 5 Sizing estimation point
Projects
Status: Closed / Done
Status: Done
Development

No branches or pull requests

3 participants