Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segment-crs): code reabability improvements to #4988 #5054

Conversation

matthewelwell
Copy link
Contributor

Changes

PR on top of #4988

Makes improvements to code-readability by adding new methods to the Condition model and updating:

  1. Variable names
  2. Method names
  3. Docstrings
  4. Comments

All of the changes are 100% superficial and do not change the behaviour of the code itself.

How did you test this code?

Continuously ran the unit tests in test_unit_segments_models throughout the process to ensure that nothing had been broken by any of the changes.

@matthewelwell matthewelwell requested a review from a team as a code owner January 29, 2025 12:06
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 3:28pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 3:28pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 3:28pm

@matthewelwell matthewelwell removed the request for review from a team January 29, 2025 12:06
@github-actions github-actions bot added the api Issue related to the REST API label Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5054 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5054 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5054 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5054 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5054 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5054 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Uffizzi Preview deployment-60393 was deleted.

@matthewelwell matthewelwell changed the title Feat/add version of to rules and conditions edits feat(segment-crs): code reabability improvements to #4988 Jan 29, 2025
@github-actions github-actions bot added the feature New feature or request label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/add_version_of_to_rules_and_conditions@6e5894e). Learn more about missing BASE report.

Additional details and impacted files
@@                              Coverage Diff                               @@
##             feat/add_version_of_to_rules_and_conditions    #5054   +/-   ##
==============================================================================
  Coverage                                               ?   97.45%           
==============================================================================
  Files                                                  ?     1216           
  Lines                                                  ?    42541           
  Branches                                               ?        0           
==============================================================================
  Hits                                                   ?    41457           
  Misses                                                 ?     1084           
  Partials                                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan merged commit fc8b581 into feat/add_version_of_to_rules_and_conditions Jan 29, 2025
34 checks passed
@zachaysan zachaysan deleted the feat/add_version_of_to_rules_and_conditions-edits branch January 29, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants