Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update identity override styles #5053

Merged
merged 2 commits into from
Feb 12, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update identity override styles
  • Loading branch information
kyle-ssg committed Jan 29, 2025
commit 03a491aa2a7121ed374b1f2b2f867a8af08735a7
21 changes: 21 additions & 0 deletions frontend/web/components/pages/UserPage.tsx
Original file line number Diff line number Diff line change
@@ -52,6 +52,8 @@ import _data from 'common/data/base/_data'
import classNames from 'classnames'
import moment from 'moment'
import { removeIdentity } from './UsersPage'
import IdentityOverridesIcon from 'components/IdentityOverridesIcon'
import SegmentOverridesIcon from 'components/SegmentOverridesIcon'

const width = [200, 48, 78]

@@ -634,6 +636,11 @@ const UserPage: FC<UserPageType> = (props) => {
flagEnabledDifferent ||
flagValueDifferent

const hasSegmentOverride =
flagValueDifferent &&
!hasUserOverride &&
!isMultiVariateOverride

const onClick = () => {
if (permission) {
editFeature(
@@ -710,6 +717,20 @@ const UserPage: FC<UserPageType> = (props) => {
>
<Icon name='copy' />
</Button>
{hasUserOverride && (
<div>
<IdentityOverridesIcon
count={1}
/>
</div>
)}
{hasSegmentOverride && (
<div>
<SegmentOverridesIcon
count={1}
/>
</div>
)}
</Row>
<TagValues
projectId={`${projectId}`}
19 changes: 0 additions & 19 deletions frontend/web/styles/project/_UserPage.scss

This file was deleted.

1 change: 0 additions & 1 deletion frontend/web/styles/project/_index.scss
Original file line number Diff line number Diff line change
@@ -9,7 +9,6 @@
@import "panel";
@import "FeaturesPage";
@import "PricingPage";
@import "UserPage";
@import "alert";
@import "icons";
@import "layout";
Loading