Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update identity override styles #5053

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jan 29, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Removes colour coded styles for identity/segment overrides
  • Adds identity/segment override icons next to features that have overrides

image

How did you test this code?

As above

@kyle-ssg kyle-ssg requested a review from a team as a code owner January 29, 2025 11:01
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team January 29, 2025 11:01
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:01am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 11:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 29, 2025 11:01am

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5053 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5053 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5053 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5053 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5053 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5053 Finished ✅ Results

@kyle-ssg kyle-ssg changed the title style: Update identity override styles feat: Update identity override styles Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Uffizzi Ephemeral Environment deployment-60390

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5053

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@matthewelwell
Copy link
Contributor

@kyle-ssg I was suggesting these icons could be used, but perhaps not exactly as they are in the environment UI. For example, the number will always just be 1, right? Also, I think it makes more sense in this context for it to be located nearer to the switch / value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI showing flag states for an Identity with different overrides is confusing
3 participants