Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(5044): handle deleted feature state #5045

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(5044): handle deleted feature state #5045

merged 1 commit into from
Jan 28, 2025

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jan 28, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Update get_skip_create_audit_log on FeatureStateValue to return False if the FeatureState is deleted.

How did you test this code?

Adds/Updates unit tests

@gagantrivedi gagantrivedi requested a review from a team as a code owner January 28, 2025 09:45
@gagantrivedi gagantrivedi requested review from matthewelwell and removed request for a team January 28, 2025 09:45
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 28, 2025 9:45am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jan 28, 2025 9:45am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jan 28, 2025 9:45am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5045 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5045 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5045 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5045 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5045 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5045 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Uffizzi Preview deployment-60340 was deleted.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (fe69d55) to head (23b8618).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5045   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files        1193     1193           
  Lines       41749    41763   +14     
=======================================
+ Hits        40664    40678   +14     
  Misses       1085     1085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi merged commit ecd409b into main Jan 28, 2025
37 checks passed
@gagantrivedi gagantrivedi deleted the fix/5044 branch January 28, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureState.DoesNotExist: FeatureState matching query does not exist.
2 participants