Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implements feature healthcare UI #5043

Merged
merged 8 commits into from
Jan 30, 2025
Merged

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 27, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Warns which environments have unhealthy features
Screenshot 2025-01-29 at 16 57 12

Displays unhealthy state reason
Screenshot 2025-01-30 at 10 44 51

Project Settings - Create provider from existing options
Screenshot 2025-01-30 at 10 51 24

Project Settings - Displays list of providers
Screenshot 2025-01-30 at 10 51 29

How did you test this code?

Manually tested using Sample Provider

@tiagoapolo tiagoapolo requested review from a team as code owners January 27, 2025 22:13
@tiagoapolo tiagoapolo requested review from kyle-ssg and zachaysan and removed request for a team January 27, 2025 22:13
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:14pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 2:14pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API labels Jan 27, 2025
@tiagoapolo tiagoapolo changed the base branch from main to feat/feature-health January 27, 2025 22:13
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5043 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5043 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5043 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5043 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5043 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5043 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Uffizzi Preview deployment-60332 was deleted.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (cc531a1) to head (6732f1b).
Report is 1 commits behind head on feat/feature-health.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/feature-health    #5043   +/-   ##
====================================================
  Coverage                97.43%   97.43%           
====================================================
  Files                     1213     1213           
  Lines                    42143    42143           
====================================================
  Hits                     41061    41061           
  Misses                    1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const [createProvider, { error, isError, isLoading, isSuccess }] =
useCreateHealthProviderMutation()

// TODO: Replace from list of provider options from API
Copy link
Contributor Author

@tiagoapolo tiagoapolo Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Replace with list of provider options from API

projectId,
})

// TODO: API Needs to expose provider id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: API Needs to expose provider id

unhealthy state in different environments.{' '}
<Button
theme='text'
href='' // TODO: Add docs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Add documentation for feature health usage

onClick={(e) => {
e.stopPropagation()
e.preventDefault()
// TODO: API Needs to expose provider id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: API Needs to expose provider id


return (
<div className='fs-caption' style={{ color: Constants.tagColors[16] }}>
{/* TODO: Provider info and link to issue will be provided by reason via the API */}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Provider info and link to issue will be provided by reason via the API

@tiagoapolo tiagoapolo merged commit 9ea58fa into main Jan 30, 2025
33 checks passed
@tiagoapolo tiagoapolo deleted the feat/feature-health-ui branch January 30, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants