fix: ensure project names are unique #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5039 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 1193 1193
Lines 41675 41690 +15
=======================================
+ Hits 40593 40608 +15
Misses 1082 1082 ☔ View full report in Codecov by Sentry. |
gagantrivedi
approved these changes
Jan 27, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures uniqueness of project names in an organisation at the API level.
Note: I originally wrote this PR to enforce the uniqueness at the database level (see here), but I realised that this might affect integrations where we tag data with the project name (e.g. influx). As such, I have enforced this only at the API level. If we want to enforce it at the DB level later on, this will at least protect us from further exacerbating the database level issue.
Fixes #5038
How did you test this code?
Wrote 2 relevant unit tests.