fix: Disable invite button when email config is not set #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoapolo
requested review from
kyle-ssg and
zachaysan
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
front-end
Docker builds report
|
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5022 ⚙️ Updating now by workflow run 12875904544. What is Uffizzi? Learn more! |
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5022 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 1192 1193 +1
Lines 41657 41667 +10
=======================================
+ Hits 40574 40585 +11
+ Misses 1083 1082 -1 ☔ View full report in Codecov by Sentry. |
tiagoapolo
force-pushed
the
fix/4036--check-email-config-is-set
branch
from
8c76462 to
8c3e355
Compare
tiagoapolo
force-pushed
the
fix/4036--check-email-config-is-set
branch
from
7900781 to
4d4a569
Compare
kyle-ssg
approved these changes
Jan 21, 2025
zachaysan
approved these changes
Jan 21, 2025
tiagoapolo
force-pushed
the
fix/4036--check-email-config-is-set
branch
from
66006f5 to
e4a5b7b
Compare
khvn26
force-pushed
the
fix/4036--check-email-config-is-set
branch
from
86e6d5d to
3adb640
Compare
khvn26
force-pushed
the
fix/4036--check-email-config-is-set
branch
from
6ab0906 to
d07d0a8
Compare
for more information, see https://pre-commit.ci
tiagoapolo
force-pushed
the
fix/4036--check-email-config-is-set
branch
from
660d3e0 to
9afc7f9
Compare
khvn26
force-pushed
the
fix/4036--check-email-config-is-set
branch
from
0909ad5 to
660d3e0
Compare
matthewelwell
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
has_email_providerfield to /version, that checks if email config was set.How did you test this code?
/accountwith no email config set in API, invite member button should be disabled and tooltip is shown when hovering.