fix: don't create feature export before launch darkly import #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
changed the title
matthewelwell
requested review from
a team and
kyle-ssg
and removed request for
a team
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
|
This change seems to have correctly removed the broken request to |
|
@matthewelwell, I added a fix for a race condition that could have been triggering the issue, could you please review it? |
|
@novakzaballa can you provide more information about the change that you made, I don't quite understand it. |
khvn26
approved these changes
Mar 11, 2024
|
Slack thread on the above topic here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes #3509
Note that it does not make much sense to run an export prior to an LD import since the import is only really useful for new projects. The feature export (I believe) was being done to create a sort of back up but it was not providing the environment id (because there is no contextual environment here).
How did you test this code?
Tested using the production preview but I'm still not seeing the correct behaviour. See comment here.