Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stale-flags): add stale flags app to installed apps #3508

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Feb 29, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add stale flags to installed apps when available on the pythonpath.

Note that this PR should allow us to get the tests passing here and hence merge that PR. Once that is complete, we can confirm that doing poetry install --with workflows also includes the stale_flags module and that the relevant logic is included when the image is built with the workflows module.

How did you test this code?

Ran integration tests in the stale flags repository.

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 11:40am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 11:40am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 11:40am

@github-actions github-actions bot added the api Issue related to the REST API label Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Uffizzi Preview deployment-47526 was deleted.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.84%. Comparing base (c2155b2) to head (ec9f562).
Report is 1 commits behind head on main.

❗ Current head ec9f562 differs from pull request most recent head 92e6635. Consider uploading reports for the commit 92e6635 to get more accurate results

Files Patch % Lines
api/app/settings/common.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   95.86%   95.84%   -0.02%     
==========================================
  Files        1099     1097       -2     
  Lines       34171    34120      -51     
==========================================
- Hits        32759    32704      -55     
- Misses       1412     1416       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 42ab1d0 Mar 11, 2024
37 checks passed
@matthewelwell matthewelwell deleted the chore(stale-flags)/add-to-installed-apps branch March 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants