3049 Use poco based parsers #3073
Draft
+4,631
−3,656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoutkramer
commented
Mar 8, 2025
| @@ -0,0 +1,197 @@ | |||
| /* | |||
There was a problem hiding this comment.
Reviewer: this file was moved - so nothing conceptually new going on here.
ewoutkramer
commented
Mar 8, 2025
| buildPocoBuilderSettings(settings)); | ||
|
|
||
|
|
||
| private static PocoBuilderSettings buildPocoBuilderSettings(ParserSettings ps) => |
There was a problem hiding this comment.
Code moved old BaseParser, which has been deleted. This was the only place it is still used.
ewoutkramer
commented
Mar 8, 2025
| public async Tasks.Task<T> ParseAsync<T>(JsonReader reader) where T : Base | ||
| => (T)await ParseAsync(reader, typeof(T)).ConfigureAwait(false); | ||
|
|
||
| /// <inheritdoc cref="ParseAsync(string, Type)" /> |
There was a problem hiding this comment.
This stuff has been moved to (legacy) extension methods you have already seen above.
ewoutkramer
commented
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes in this PR.
Related issues
Closes|Fixes|Resolves [issue #].
Testing
Describe how this change was tested.
FirelyTeam Checklist