Skip to content

Document new protocol versions in wireprotocol #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrotteveel opened this issue Mar 1, 2025 · 2 comments
Open

Document new protocol versions in wireprotocol #216

mrotteveel opened this issue Mar 1, 2025 · 2 comments
Assignees

Comments

@mrotteveel
Copy link
Member

Currently, wireprotocol documents version 10, and some parts of version 11 and 16 (batches).

@mrotteveel mrotteveel self-assigned this Mar 1, 2025
@einar-hjortdal
Copy link

I am stuck at parsing protocol 18 row data. this chapter of the documentation doesn't help 😿

@mrotteveel
Copy link
Member Author

Yes, that section still needs to be written :/

The problem seems to be that you calculate the wrong length for the null bitset, which results in an off-by-4 error in reading the response (depending on the number of columns you're selecting):

Specifically:

if xsqlda.vars.len % 8 == 0 {

should be

if xsqlda.vars.len % 8 != 0 {

Though I would actually recommend to remove that if and instead use

mut n := (i32(xsqlda.vars.len) + 7) / 8

einar-hjortdal added a commit to einar-hjortdal/firebird that referenced this issue Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants