Merge pull request #52 from Financial-Times/upgrade-node-version-to-v12

Upgrade Node version -> v12
Financial-Times · Jun 17, 2020 · 4bf71aa · 4bf71aa
2 parents b1ee184 + a427eb7
commit 4bf71aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -3,15 +3,15 @@
 
 references:
 
-  container_config_node8: &container_config_node8
+  container_config_node12: &container_config_node12
     working_directory: ~/project/build
     docker:
-      - image: circleci/node:8-browsers
+      - image: circleci/node:12-browsers
 
-  container_config_lambda_node8: &container_config_lambda_node8
+  container_config_lambda_node12: &container_config_lambda_node12
     working_directory: ~/project/build
     docker:
-      - image: lambci/lambda:build-nodejs8.10
+      - image: lambci/lambda:build-nodejs12.x
 
   workspace_root: &workspace_root
     ~/project
@@ -60,7 +60,7 @@ version: 2
 jobs:
 
   build:
-    <<: *container_config_node8
+    <<: *container_config_node12
     steps:
       - checkout
       - run:
@@ -90,7 +90,7 @@ jobs:
             - build
 
   test:
-    <<: *container_config_node8
+    <<: *container_config_node12
     steps:
       - *attach_workspace
       - run:
@@ -106,7 +106,7 @@ jobs:
           destination: test-results
 
   publish:
-    <<: *container_config_node8
+    <<: *container_config_node12
     steps:
       - *attach_workspace
       - run:

diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
     "webpack": "^2.2.1"
   },
   "engines": {
-    "node": "^6"
+    "node": "12.x"
   },
   "scripts": {
     "precommit": "node_modules/.bin/secret-squirrel",