return null breadcrumb ld when there are no items

Financial-Times · May 23, 2022 · b02cf6d · b02cf6d
1 parent 66b04f7
commit b02cf6d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/test/types/breadcrumb.spec.js b/test/types/breadcrumb.spec.js
@@ -131,7 +131,6 @@ describe('Type: Breadcrumb', function () {
 		auxArticle.displayConcept = null;
 		delete auxArticle.displayConcept;
 		const result = breadcrumb(auxArticle);
-		expect(result).to.contain({ '@context': 'https://schema.org', '@type': 'BreadcrumbList' });
-		expect(result.itemListElement.length).to.equals(0);
+		expect(result).to.equal(null);
 	});
 });
diff --git a/types/breadcrumb.js b/types/breadcrumb.js
@@ -83,10 +83,14 @@ function getBreadcrumbItem (index,name,url){
 }
 
 module.exports = (content) => {
+	const items = getBreadcrumbItems(content);
+	if(!items || items.length <= 0)
+		return null;
+
 	const baseSchema = {
 		'@context': 'https://schema.org',
 		'@type': 'BreadcrumbList',
-		'itemListElement' : getBreadcrumbItems(content)
+		'itemListElement' : items
 	};
 
 	return baseSchema;