Skip to content

Commit

Permalink
Merge pull request #141 from Financial-Times/drop-old-node-versions
Browse files Browse the repository at this point in the history
Drop Node.js 16 support
  • Loading branch information
rowanmanning authored Jul 3, 2024
2 parents efeaea0 + 80cd523 commit 1da1936
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 23 deletions.
27 changes: 9 additions & 18 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,10 @@ orbs:
executors:
node:
docker:
- image: cimg/node:20.11
node18_19:
- image: cimg/node:20.15
node18_20:
docker:
- image: cimg/node:18.19
node16_20:
docker:
- image: cimg/node:16.20
- image: cimg/node:18.20
jobs:
checkout:
docker:
Expand Down Expand Up @@ -46,8 +43,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- node18_20
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand All @@ -59,8 +55,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- node18_20
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand All @@ -72,8 +67,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- node18_20
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand Down Expand Up @@ -107,8 +101,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- node18_20
- tool-kit/build:
name: tool-kit/build-<< matrix.executor >>
requires:
Expand All @@ -117,8 +110,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- node18_20
- tool-kit/test:
name: tool-kit/test-<< matrix.executor >>
requires:
Expand All @@ -127,5 +119,4 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- node18_20
5 changes: 2 additions & 3 deletions .toolkitrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ hooks:
options:
'@dotcom-tool-kit/circleci':
nodeVersion:
- '20.11'
- '18.19'
- '16.20'
- '20.15'
- '18.20'
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"start": "dotcom-tool-kit run:local"
},
"engines": {
"node": "16.x || 18.x || 20.x",
"node": "18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"husky": {
Expand Down

0 comments on commit 1da1936

Please sign in to comment.