fix: add type declarations for serialize-request #940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds manual type declarations for serialize-request which should make it work in most projects. The tests are now passing.
The compromise is this:
esModuleInterop
set totrue
)esModuleInterop
set tofalse
)esModuleInterop
set totrue
)esModuleInterop
set tofalse
)In the ❌ed projects above everything will still work but you won't get type hinting in VSCode and the types will be
any
. I'm not sure if it's possible to fix this without breaking the other module systems which are more commonly-used.